Is instantiating a GUID in Entity Framework Core bad practice?
If I have a model with a key of type Guid, is it bad practise to set the ID explicitly in the constructor?
I know it will be set implicitly by Entity Framework, but will anything bad happen (perhaps performance wise) from setting it explicitly?
Example:
class MyModel
{
public MyModel()
{
Id = Guid.NewGuid();
}
[Key]
public Guid Id { get; set; }
}
I'm thinking a Guid is backed up by a sequential ID in SQL server, and if I set a value explicitly, I suppose I will decrease indexing performance because it will no longer be sequential?
I have not been able to find an answer on this and I am highly curious about it.
c# entity-framework-core guid
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
add a comment |
If I have a model with a key of type Guid, is it bad practise to set the ID explicitly in the constructor?
I know it will be set implicitly by Entity Framework, but will anything bad happen (perhaps performance wise) from setting it explicitly?
Example:
class MyModel
{
public MyModel()
{
Id = Guid.NewGuid();
}
[Key]
public Guid Id { get; set; }
}
I'm thinking a Guid is backed up by a sequential ID in SQL server, and if I set a value explicitly, I suppose I will decrease indexing performance because it will no longer be sequential?
I have not been able to find an answer on this and I am highly curious about it.
c# entity-framework-core guid
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
1
Test it yourself. Create 100000 entities and let EF assign the GUID. Profile a few queries against it. Wipe the table, then create 100000 entities with a GUID you new up yourself and profile that. I will assume (and it is only an assumption), that there'll be no difference.
– JᴀʏMᴇᴇ
Nov 20 '18 at 14:03
1
guids aren't sequential though. They tend to be if generated by the same system, but that seems foolish to rely on.
– JNevill
Nov 20 '18 at 14:03
The SQL datatype for a .Net Guid is auniqueidentifier
– Oliver
Nov 20 '18 at 14:04
add a comment |
If I have a model with a key of type Guid, is it bad practise to set the ID explicitly in the constructor?
I know it will be set implicitly by Entity Framework, but will anything bad happen (perhaps performance wise) from setting it explicitly?
Example:
class MyModel
{
public MyModel()
{
Id = Guid.NewGuid();
}
[Key]
public Guid Id { get; set; }
}
I'm thinking a Guid is backed up by a sequential ID in SQL server, and if I set a value explicitly, I suppose I will decrease indexing performance because it will no longer be sequential?
I have not been able to find an answer on this and I am highly curious about it.
c# entity-framework-core guid
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
If I have a model with a key of type Guid, is it bad practise to set the ID explicitly in the constructor?
I know it will be set implicitly by Entity Framework, but will anything bad happen (perhaps performance wise) from setting it explicitly?
Example:
class MyModel
{
public MyModel()
{
Id = Guid.NewGuid();
}
[Key]
public Guid Id { get; set; }
}
I'm thinking a Guid is backed up by a sequential ID in SQL server, and if I set a value explicitly, I suppose I will decrease indexing performance because it will no longer be sequential?
I have not been able to find an answer on this and I am highly curious about it.
c# entity-framework-core guid
c# entity-framework-core guid
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
edited Nov 21 '18 at 3:00
TanvirArjel
8,67432046
8,67432046
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
asked Nov 20 '18 at 14:00
Mathias Lykkegaard LorenzenMathias Lykkegaard Lorenzen
6,8731770142
6,8731770142
1
Test it yourself. Create 100000 entities and let EF assign the GUID. Profile a few queries against it. Wipe the table, then create 100000 entities with a GUID you new up yourself and profile that. I will assume (and it is only an assumption), that there'll be no difference.
– JᴀʏMᴇᴇ
Nov 20 '18 at 14:03
1
guids aren't sequential though. They tend to be if generated by the same system, but that seems foolish to rely on.
– JNevill
Nov 20 '18 at 14:03
The SQL datatype for a .Net Guid is auniqueidentifier
– Oliver
Nov 20 '18 at 14:04
add a comment |
1
Test it yourself. Create 100000 entities and let EF assign the GUID. Profile a few queries against it. Wipe the table, then create 100000 entities with a GUID you new up yourself and profile that. I will assume (and it is only an assumption), that there'll be no difference.
– JᴀʏMᴇᴇ
Nov 20 '18 at 14:03
1
guids aren't sequential though. They tend to be if generated by the same system, but that seems foolish to rely on.
– JNevill
Nov 20 '18 at 14:03
The SQL datatype for a .Net Guid is auniqueidentifier
– Oliver
Nov 20 '18 at 14:04
1
1
Test it yourself. Create 100000 entities and let EF assign the GUID. Profile a few queries against it. Wipe the table, then create 100000 entities with a GUID you new up yourself and profile that. I will assume (and it is only an assumption), that there'll be no difference.
– JᴀʏMᴇᴇ
Nov 20 '18 at 14:03
Test it yourself. Create 100000 entities and let EF assign the GUID. Profile a few queries against it. Wipe the table, then create 100000 entities with a GUID you new up yourself and profile that. I will assume (and it is only an assumption), that there'll be no difference.
– JᴀʏMᴇᴇ
Nov 20 '18 at 14:03
1
1
guids aren't sequential though. They tend to be if generated by the same system, but that seems foolish to rely on.
– JNevill
Nov 20 '18 at 14:03
guids aren't sequential though. They tend to be if generated by the same system, but that seems foolish to rely on.
– JNevill
Nov 20 '18 at 14:03
The SQL datatype for a .Net Guid is a
uniqueidentifier– Oliver
Nov 20 '18 at 14:04
The SQL datatype for a .Net Guid is a
uniqueidentifier– Oliver
Nov 20 '18 at 14:04
add a comment |
1 Answer
1
active
oldest
votes
I see a design flaw rather than a performance problem: models shouldn't generate their id. It's out of their responsibility. Repositories do so in the Add method.
Guid can be generated in many ways: for example, it can be random or sequential. There're different algorithms to generate them either way. Therefore, you're closing your choices to just one.
And you're forcing the moment on which the model id is assigned: you mighn't want this in order to delay its assignment until the model may need to be persisted. For example, a zero Guid may be useful to know that some model isn't persistent yet.
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53394676%2fis-instantiating-a-guid-in-entity-framework-core-bad-practice%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
I see a design flaw rather than a performance problem: models shouldn't generate their id. It's out of their responsibility. Repositories do so in the Add method.
Guid can be generated in many ways: for example, it can be random or sequential. There're different algorithms to generate them either way. Therefore, you're closing your choices to just one.
And you're forcing the moment on which the model id is assigned: you mighn't want this in order to delay its assignment until the model may need to be persisted. For example, a zero Guid may be useful to know that some model isn't persistent yet.
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
add a comment |
I see a design flaw rather than a performance problem: models shouldn't generate their id. It's out of their responsibility. Repositories do so in the Add method.
Guid can be generated in many ways: for example, it can be random or sequential. There're different algorithms to generate them either way. Therefore, you're closing your choices to just one.
And you're forcing the moment on which the model id is assigned: you mighn't want this in order to delay its assignment until the model may need to be persisted. For example, a zero Guid may be useful to know that some model isn't persistent yet.
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
add a comment |
I see a design flaw rather than a performance problem: models shouldn't generate their id. It's out of their responsibility. Repositories do so in the Add method.
Guid can be generated in many ways: for example, it can be random or sequential. There're different algorithms to generate them either way. Therefore, you're closing your choices to just one.
And you're forcing the moment on which the model id is assigned: you mighn't want this in order to delay its assignment until the model may need to be persisted. For example, a zero Guid may be useful to know that some model isn't persistent yet.
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
I see a design flaw rather than a performance problem: models shouldn't generate their id. It's out of their responsibility. Repositories do so in the Add method.
Guid can be generated in many ways: for example, it can be random or sequential. There're different algorithms to generate them either way. Therefore, you're closing your choices to just one.
And you're forcing the moment on which the model id is assigned: you mighn't want this in order to delay its assignment until the model may need to be persisted. For example, a zero Guid may be useful to know that some model isn't persistent yet.
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
edited Nov 20 '18 at 14:13
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
answered Nov 20 '18 at 14:07
Matías FidemraizerMatías Fidemraizer
49.5k1283148
49.5k1283148
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53394676%2fis-instantiating-a-guid-in-entity-framework-core-bad-practice%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Test it yourself. Create 100000 entities and let EF assign the GUID. Profile a few queries against it. Wipe the table, then create 100000 entities with a GUID you new up yourself and profile that. I will assume (and it is only an assumption), that there'll be no difference.
– JᴀʏMᴇᴇ
Nov 20 '18 at 14:03
1
guids aren't sequential though. They tend to be if generated by the same system, but that seems foolish to rely on.
– JNevill
Nov 20 '18 at 14:03
The SQL datatype for a .Net Guid is a
uniqueidentifier– Oliver
Nov 20 '18 at 14:04