Cfrgtkky

I am attempting to populate a moving average queue but I am getting the same date and close for all of the objects in the moving average queue. I am stuck as how to not get the reference pointing to the same object instead of getting the current value in the object and placing that value on the queue.

public class MA

{

    public static Queue<DateClose> MAMethod(Queue<DateClose> queue,

        Deque<DateClose> firstMASample, int period)

    {

        Deque<DateClose> sample = new Deque<DateClose>(firstMASample.ToArray());

        Queue<DateClose> movingAverageQueue = new Queue<DateClose>(queue.Count() + 1);

        // get the last item or initial MA value from the queue

        DateClose mA = sample.RemoveFromBack();

        DateClose dateClose = null;

        decimal sub = 0;

        DateClose add = null;

        //put the initial Ma value on the movingAverageQueue

        movingAverageQueue.Enqueue(mA);

        foreach (DateClose d in queue.ToList())

        {

            dateClose = sample.RemoveFromFront();

            sub = dateClose.Close;

            // subtract previous closing from new current MA

            mA.Close = mA.Close - sub/period;

            // add the new closing to new current MA

            add = d;

            sample.AddToBack(d);

            mA.Close = mA.Close + add.Close/period;

            mA.Date = add.Date;

            movingAverageQueue.Enqueue(mA);

            queue.Dequeue();

        }



        return movingAverageQueue;

    }

}

movingAverageQueue has all the same Date and Close values.

I solved this of accessing by value instead of by reference with creating two new objects in the for loop, It works!

        public static Deque<DateClose> MAMethod(Queue<DateClose> queue,

        Deque<DateClose> firstMASample, int period)

    {

        Deque<DateClose> sample = new Deque<DateClose>(firstMASample.ToArray());

        Deque<DateClose> movingAverageQueue = new Deque<DateClose>(queue.Count() + 1);

        // get the last item or initial MA value from the queue

        DateClose mA = sample.RemoveFromBack();

        //DateClose dateClose = null;

        decimal sub = 0;

        DateClose add = null;

        //put the initial Ma value on the movingAverageQueue

        movingAverageQueue.AddToBack(mA);

        foreach (DateClose d in queue.ToList())

        {

            // create a new object for add subtraction moving averages           

            DateClose dateClose = new DateClose(sample.RemoveFromFront());

            sub = dateClose.Close;

            // create a new object to place the new moving average on the queue

            DateClose mAQueueValue = new DateClose(movingAverageQueue.Last());

            // subtract previous closing from new current MA



            mAQueueValue.Close = mAQueueValue.Close - sub/period;

            // add the new closing to new current MA

            add = d;

            sample.AddToBack(d);

            mAQueueValue.Close = mAQueueValue.Close + add.Close/period;

            mAQueueValue.Date = add.Date;

            movingAverageQueue.AddToBack(mAQueueValue);

            queue.Dequeue();

        }



        return movingAverageQueue;

    }