JavaScript .map not rendering chrome.topSites in React
I'm trying to render a list of titles from Chrome's topSites api for a chrome extension.
When I log it to the console I get this:
[
{
"title": "Chrome Web Store",
"url": "https://chrome.google.com/webstore?hl=en"
}
]
However, the following doesn't render anything to the page
render() {
return (
<ul>
{
chrome.topSites.get(data => {
console.log(data);
data.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
});
})
}
</ul>
);
}
Expected output:
A p
tag with the title of the site gets rendered to the screen
Actual output:
Nothing is rendered on screen
javascript reactjs google-chrome-extension
add a comment |
I'm trying to render a list of titles from Chrome's topSites api for a chrome extension.
When I log it to the console I get this:
[
{
"title": "Chrome Web Store",
"url": "https://chrome.google.com/webstore?hl=en"
}
]
However, the following doesn't render anything to the page
render() {
return (
<ul>
{
chrome.topSites.get(data => {
console.log(data);
data.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
});
})
}
</ul>
);
}
Expected output:
A p
tag with the title of the site gets rendered to the screen
Actual output:
Nothing is rendered on screen
javascript reactjs google-chrome-extension
You need to addreturn
before thedata.map(site => { ... })
as well.
– Tholle
Nov 21 '18 at 17:32
2
Callbacks in extension API are invoked asynchronously so returning a value from them won't return it into the outer context. I don't know React but you'll have to rework the code - for example so that the callback only sets the state, and move chrome.topSites.get call out of render()
– wOxxOm
Nov 21 '18 at 17:33
@wOxxOm thanks. I moved chrome.topSites out to the componentDidMount and set the state when it mounted and used the component's state to map the list on the page
– JuwanP
Nov 21 '18 at 17:50
add a comment |
I'm trying to render a list of titles from Chrome's topSites api for a chrome extension.
When I log it to the console I get this:
[
{
"title": "Chrome Web Store",
"url": "https://chrome.google.com/webstore?hl=en"
}
]
However, the following doesn't render anything to the page
render() {
return (
<ul>
{
chrome.topSites.get(data => {
console.log(data);
data.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
});
})
}
</ul>
);
}
Expected output:
A p
tag with the title of the site gets rendered to the screen
Actual output:
Nothing is rendered on screen
javascript reactjs google-chrome-extension
I'm trying to render a list of titles from Chrome's topSites api for a chrome extension.
When I log it to the console I get this:
[
{
"title": "Chrome Web Store",
"url": "https://chrome.google.com/webstore?hl=en"
}
]
However, the following doesn't render anything to the page
render() {
return (
<ul>
{
chrome.topSites.get(data => {
console.log(data);
data.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
});
})
}
</ul>
);
}
Expected output:
A p
tag with the title of the site gets rendered to the screen
Actual output:
Nothing is rendered on screen
javascript reactjs google-chrome-extension
javascript reactjs google-chrome-extension
asked Nov 21 '18 at 17:29
JuwanPJuwanP
112
112
You need to addreturn
before thedata.map(site => { ... })
as well.
– Tholle
Nov 21 '18 at 17:32
2
Callbacks in extension API are invoked asynchronously so returning a value from them won't return it into the outer context. I don't know React but you'll have to rework the code - for example so that the callback only sets the state, and move chrome.topSites.get call out of render()
– wOxxOm
Nov 21 '18 at 17:33
@wOxxOm thanks. I moved chrome.topSites out to the componentDidMount and set the state when it mounted and used the component's state to map the list on the page
– JuwanP
Nov 21 '18 at 17:50
add a comment |
You need to addreturn
before thedata.map(site => { ... })
as well.
– Tholle
Nov 21 '18 at 17:32
2
Callbacks in extension API are invoked asynchronously so returning a value from them won't return it into the outer context. I don't know React but you'll have to rework the code - for example so that the callback only sets the state, and move chrome.topSites.get call out of render()
– wOxxOm
Nov 21 '18 at 17:33
@wOxxOm thanks. I moved chrome.topSites out to the componentDidMount and set the state when it mounted and used the component's state to map the list on the page
– JuwanP
Nov 21 '18 at 17:50
You need to add
return
before the data.map(site => { ... })
as well.– Tholle
Nov 21 '18 at 17:32
You need to add
return
before the data.map(site => { ... })
as well.– Tholle
Nov 21 '18 at 17:32
2
2
Callbacks in extension API are invoked asynchronously so returning a value from them won't return it into the outer context. I don't know React but you'll have to rework the code - for example so that the callback only sets the state, and move chrome.topSites.get call out of render()
– wOxxOm
Nov 21 '18 at 17:33
Callbacks in extension API are invoked asynchronously so returning a value from them won't return it into the outer context. I don't know React but you'll have to rework the code - for example so that the callback only sets the state, and move chrome.topSites.get call out of render()
– wOxxOm
Nov 21 '18 at 17:33
@wOxxOm thanks. I moved chrome.topSites out to the componentDidMount and set the state when it mounted and used the component's state to map the list on the page
– JuwanP
Nov 21 '18 at 17:50
@wOxxOm thanks. I moved chrome.topSites out to the componentDidMount and set the state when it mounted and used the component's state to map the list on the page
– JuwanP
Nov 21 '18 at 17:50
add a comment |
2 Answers
2
active
oldest
votes
This ended up working for me. Moving chrome.topSites.get into
componendDidMount()and assigning it to state. Then mapping the
this.state.sites` to the page in the render method.
export default class TopSites extends Component {
constructor(props) {
super(props);
this.state = {
sites: ,
}
}
componentDidMount() {
chrome.topSites.get(data => {
this.setState({
sites: data
});
});
}
render() {
const {sites} = this.state;
return (
<ul>
{sites.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
})}
</ul>
);
}
}
add a comment |
state= {
data: '',
}
// declaring a async function
getData = async () => {
const result = await chrome.topSites.get(); // waiting for the result
this.setState({ data: result});
}
componentDidMount(){
this.getData();
}
render(){
const list = this.state.data ? this.state.data.map((val) => <li key={val.title}> {val.title}
</li> : null)
return(
<ul>
{list}
</ul>
)
}
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53417636%2fjavascript-map-not-rendering-chrome-topsites-in-react%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
This ended up working for me. Moving chrome.topSites.get into
componendDidMount()and assigning it to state. Then mapping the
this.state.sites` to the page in the render method.
export default class TopSites extends Component {
constructor(props) {
super(props);
this.state = {
sites: ,
}
}
componentDidMount() {
chrome.topSites.get(data => {
this.setState({
sites: data
});
});
}
render() {
const {sites} = this.state;
return (
<ul>
{sites.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
})}
</ul>
);
}
}
add a comment |
This ended up working for me. Moving chrome.topSites.get into
componendDidMount()and assigning it to state. Then mapping the
this.state.sites` to the page in the render method.
export default class TopSites extends Component {
constructor(props) {
super(props);
this.state = {
sites: ,
}
}
componentDidMount() {
chrome.topSites.get(data => {
this.setState({
sites: data
});
});
}
render() {
const {sites} = this.state;
return (
<ul>
{sites.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
})}
</ul>
);
}
}
add a comment |
This ended up working for me. Moving chrome.topSites.get into
componendDidMount()and assigning it to state. Then mapping the
this.state.sites` to the page in the render method.
export default class TopSites extends Component {
constructor(props) {
super(props);
this.state = {
sites: ,
}
}
componentDidMount() {
chrome.topSites.get(data => {
this.setState({
sites: data
});
});
}
render() {
const {sites} = this.state;
return (
<ul>
{sites.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
})}
</ul>
);
}
}
This ended up working for me. Moving chrome.topSites.get into
componendDidMount()and assigning it to state. Then mapping the
this.state.sites` to the page in the render method.
export default class TopSites extends Component {
constructor(props) {
super(props);
this.state = {
sites: ,
}
}
componentDidMount() {
chrome.topSites.get(data => {
this.setState({
sites: data
});
});
}
render() {
const {sites} = this.state;
return (
<ul>
{sites.map(site => {
return (
<li key={site.title}>
{site.title}
</li>
);
})}
</ul>
);
}
}
answered Nov 21 '18 at 18:06
JuwanPJuwanP
112
112
add a comment |
add a comment |
state= {
data: '',
}
// declaring a async function
getData = async () => {
const result = await chrome.topSites.get(); // waiting for the result
this.setState({ data: result});
}
componentDidMount(){
this.getData();
}
render(){
const list = this.state.data ? this.state.data.map((val) => <li key={val.title}> {val.title}
</li> : null)
return(
<ul>
{list}
</ul>
)
}
add a comment |
state= {
data: '',
}
// declaring a async function
getData = async () => {
const result = await chrome.topSites.get(); // waiting for the result
this.setState({ data: result});
}
componentDidMount(){
this.getData();
}
render(){
const list = this.state.data ? this.state.data.map((val) => <li key={val.title}> {val.title}
</li> : null)
return(
<ul>
{list}
</ul>
)
}
add a comment |
state= {
data: '',
}
// declaring a async function
getData = async () => {
const result = await chrome.topSites.get(); // waiting for the result
this.setState({ data: result});
}
componentDidMount(){
this.getData();
}
render(){
const list = this.state.data ? this.state.data.map((val) => <li key={val.title}> {val.title}
</li> : null)
return(
<ul>
{list}
</ul>
)
}
state= {
data: '',
}
// declaring a async function
getData = async () => {
const result = await chrome.topSites.get(); // waiting for the result
this.setState({ data: result});
}
componentDidMount(){
this.getData();
}
render(){
const list = this.state.data ? this.state.data.map((val) => <li key={val.title}> {val.title}
</li> : null)
return(
<ul>
{list}
</ul>
)
}
answered Nov 21 '18 at 18:04
md.warish Ansarimd.warish Ansari
772
772
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53417636%2fjavascript-map-not-rendering-chrome-topsites-in-react%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
You need to add
return
before thedata.map(site => { ... })
as well.– Tholle
Nov 21 '18 at 17:32
2
Callbacks in extension API are invoked asynchronously so returning a value from them won't return it into the outer context. I don't know React but you'll have to rework the code - for example so that the callback only sets the state, and move chrome.topSites.get call out of render()
– wOxxOm
Nov 21 '18 at 17:33
@wOxxOm thanks. I moved chrome.topSites out to the componentDidMount and set the state when it mounted and used the component's state to map the list on the page
– JuwanP
Nov 21 '18 at 17:50