Unable to create brave tracer
I am creating a Servlet Filter as a independent jar (using brave as part of spring sleuth-Greenwich.BUILD-SNAPSHOT) so that it can be used in Spring boot app. I have created a filter and included in my spring boot app. But while doing so, it always returns null pointer exception (although it creates a half baked span in zipkin server) as shown below:
package com.somepackage;
import brave.ScopedSpan;
import brave.Span;
import brave.Tracer;
import brave.Tracing;
public class TestFilter implements Filter {
@Autowired
private Tracer tracer;
@Autowired
Span span;
@Autowired
private Tracing tracing;
FilterConfig filterConfig;
@Override
public void init(FilterConfig filterConfig) throws ServletException {
this.filterConfig = filterConfig;
}
@Override
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
throws IOException, ServletException {
if (request instanceof HttpServletRequest) {
final HttpServletRequest httpServletRequest = (HttpServletRequest) request;
String contextPath = httpServletRequest.getServletPath();
StringBuffer requestUrl = httpServletRequest.getRequestURL();
//always return null pointer at the below line 1. ??
Span span = tracer.newTrace().name("some-span-name").start(); //line 1
try {
span.tag("context-path", contextPath);
String logId = MDC.get(LOG_ID); //Assuming a key in MDC
span.tag("LOG_ID", correlationId);
span.tag("ENV", "dev");
chain.doFilter(request, response);
} catch (RuntimeException | Error e) {
span.error(e);
throw e;
} finally {
span.finish(); // always finish the span
}
}
}
@Override
public void destroy() {}
}
{"thread":"http-nio-8080-exec-2","level":"ERROR","loggerName":"org.springframework.cloud.sleuth.instrument.web.ExceptionLoggingFilter","message":"Uncaught exception thrown","thrown":{"commonElementCount":0,"name":"java.lang.NullPointerException","extendedStackTrace":[{"class":"com.somepackage.TestFilter","method":"doFilter","file":"EmZipkinFilter.java","line":37,"exact":false,"location":"testzipkin-1.0-SNAPSHOT.jar!/","version":"?"}
spring zipkin brave
add a comment |
I am creating a Servlet Filter as a independent jar (using brave as part of spring sleuth-Greenwich.BUILD-SNAPSHOT) so that it can be used in Spring boot app. I have created a filter and included in my spring boot app. But while doing so, it always returns null pointer exception (although it creates a half baked span in zipkin server) as shown below:
package com.somepackage;
import brave.ScopedSpan;
import brave.Span;
import brave.Tracer;
import brave.Tracing;
public class TestFilter implements Filter {
@Autowired
private Tracer tracer;
@Autowired
Span span;
@Autowired
private Tracing tracing;
FilterConfig filterConfig;
@Override
public void init(FilterConfig filterConfig) throws ServletException {
this.filterConfig = filterConfig;
}
@Override
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
throws IOException, ServletException {
if (request instanceof HttpServletRequest) {
final HttpServletRequest httpServletRequest = (HttpServletRequest) request;
String contextPath = httpServletRequest.getServletPath();
StringBuffer requestUrl = httpServletRequest.getRequestURL();
//always return null pointer at the below line 1. ??
Span span = tracer.newTrace().name("some-span-name").start(); //line 1
try {
span.tag("context-path", contextPath);
String logId = MDC.get(LOG_ID); //Assuming a key in MDC
span.tag("LOG_ID", correlationId);
span.tag("ENV", "dev");
chain.doFilter(request, response);
} catch (RuntimeException | Error e) {
span.error(e);
throw e;
} finally {
span.finish(); // always finish the span
}
}
}
@Override
public void destroy() {}
}
{"thread":"http-nio-8080-exec-2","level":"ERROR","loggerName":"org.springframework.cloud.sleuth.instrument.web.ExceptionLoggingFilter","message":"Uncaught exception thrown","thrown":{"commonElementCount":0,"name":"java.lang.NullPointerException","extendedStackTrace":[{"class":"com.somepackage.TestFilter","method":"doFilter","file":"EmZipkinFilter.java","line":37,"exact":false,"location":"testzipkin-1.0-SNAPSHOT.jar!/","version":"?"}
spring zipkin brave
add a comment |
I am creating a Servlet Filter as a independent jar (using brave as part of spring sleuth-Greenwich.BUILD-SNAPSHOT) so that it can be used in Spring boot app. I have created a filter and included in my spring boot app. But while doing so, it always returns null pointer exception (although it creates a half baked span in zipkin server) as shown below:
package com.somepackage;
import brave.ScopedSpan;
import brave.Span;
import brave.Tracer;
import brave.Tracing;
public class TestFilter implements Filter {
@Autowired
private Tracer tracer;
@Autowired
Span span;
@Autowired
private Tracing tracing;
FilterConfig filterConfig;
@Override
public void init(FilterConfig filterConfig) throws ServletException {
this.filterConfig = filterConfig;
}
@Override
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
throws IOException, ServletException {
if (request instanceof HttpServletRequest) {
final HttpServletRequest httpServletRequest = (HttpServletRequest) request;
String contextPath = httpServletRequest.getServletPath();
StringBuffer requestUrl = httpServletRequest.getRequestURL();
//always return null pointer at the below line 1. ??
Span span = tracer.newTrace().name("some-span-name").start(); //line 1
try {
span.tag("context-path", contextPath);
String logId = MDC.get(LOG_ID); //Assuming a key in MDC
span.tag("LOG_ID", correlationId);
span.tag("ENV", "dev");
chain.doFilter(request, response);
} catch (RuntimeException | Error e) {
span.error(e);
throw e;
} finally {
span.finish(); // always finish the span
}
}
}
@Override
public void destroy() {}
}
{"thread":"http-nio-8080-exec-2","level":"ERROR","loggerName":"org.springframework.cloud.sleuth.instrument.web.ExceptionLoggingFilter","message":"Uncaught exception thrown","thrown":{"commonElementCount":0,"name":"java.lang.NullPointerException","extendedStackTrace":[{"class":"com.somepackage.TestFilter","method":"doFilter","file":"EmZipkinFilter.java","line":37,"exact":false,"location":"testzipkin-1.0-SNAPSHOT.jar!/","version":"?"}
spring zipkin brave
I am creating a Servlet Filter as a independent jar (using brave as part of spring sleuth-Greenwich.BUILD-SNAPSHOT) so that it can be used in Spring boot app. I have created a filter and included in my spring boot app. But while doing so, it always returns null pointer exception (although it creates a half baked span in zipkin server) as shown below:
package com.somepackage;
import brave.ScopedSpan;
import brave.Span;
import brave.Tracer;
import brave.Tracing;
public class TestFilter implements Filter {
@Autowired
private Tracer tracer;
@Autowired
Span span;
@Autowired
private Tracing tracing;
FilterConfig filterConfig;
@Override
public void init(FilterConfig filterConfig) throws ServletException {
this.filterConfig = filterConfig;
}
@Override
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
throws IOException, ServletException {
if (request instanceof HttpServletRequest) {
final HttpServletRequest httpServletRequest = (HttpServletRequest) request;
String contextPath = httpServletRequest.getServletPath();
StringBuffer requestUrl = httpServletRequest.getRequestURL();
//always return null pointer at the below line 1. ??
Span span = tracer.newTrace().name("some-span-name").start(); //line 1
try {
span.tag("context-path", contextPath);
String logId = MDC.get(LOG_ID); //Assuming a key in MDC
span.tag("LOG_ID", correlationId);
span.tag("ENV", "dev");
chain.doFilter(request, response);
} catch (RuntimeException | Error e) {
span.error(e);
throw e;
} finally {
span.finish(); // always finish the span
}
}
}
@Override
public void destroy() {}
}
{"thread":"http-nio-8080-exec-2","level":"ERROR","loggerName":"org.springframework.cloud.sleuth.instrument.web.ExceptionLoggingFilter","message":"Uncaught exception thrown","thrown":{"commonElementCount":0,"name":"java.lang.NullPointerException","extendedStackTrace":[{"class":"com.somepackage.TestFilter","method":"doFilter","file":"EmZipkinFilter.java","line":37,"exact":false,"location":"testzipkin-1.0-SNAPSHOT.jar!/","version":"?"}
spring zipkin brave
spring zipkin brave
edited Nov 20 '18 at 14:38
user8479984
asked Nov 20 '18 at 14:24
user8479984user8479984
115
115
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53395123%2funable-to-create-brave-tracer%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53395123%2funable-to-create-brave-tracer%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown