Variable Naming Convention












0















I'm working on a Front End system using ReactJS.



I'm following Airbnb javascript style guide.
But the API response from the Back End is using JSON with underscored variable names.



This causing inconsistencies in our codes. Are there any good solution for this? Is it common to convert the field names from API response? (i.e the JSON field 'product_id' will be converted to 'productId')



const { filter } = this.state;

const filterList = filter.list.map((item, index) => (
<li
key={index}
className={`border-bottom ${item.active ? 'active' : ''}`}
>
<a onClick={this.setFilter(item.product_id)}>{item.product_name}</a>
</li>
));

return (
<ul className="sort-list grid-container">
{filterList}
</ul>
);


in the code sample above, we saw variable written in camel case, and underscore. There's not much technical issue. Just the variable naming inconsistencies. I just wondering if this small issue should be tackled or not.










share|improve this question

























  • "causing inconsistencies" isn't a concrete problem to which anyone could offer a solution. What actual issue is it giving you? Show some code and data which causes you a definable problem which someone could post a practical answer to. As for the naming convention question, that's purely a matter of opinion really.

    – ADyson
    Nov 14 '18 at 9:25













  • Is it common to convert the field names from API response? - it is. There are case conversion libs but they may be not needed if JSON response doesn't conform front end data structure. Unless back end was designed to take how data is used at front end into account, data structure may differ a lot.

    – estus
    Nov 14 '18 at 9:27
















0















I'm working on a Front End system using ReactJS.



I'm following Airbnb javascript style guide.
But the API response from the Back End is using JSON with underscored variable names.



This causing inconsistencies in our codes. Are there any good solution for this? Is it common to convert the field names from API response? (i.e the JSON field 'product_id' will be converted to 'productId')



const { filter } = this.state;

const filterList = filter.list.map((item, index) => (
<li
key={index}
className={`border-bottom ${item.active ? 'active' : ''}`}
>
<a onClick={this.setFilter(item.product_id)}>{item.product_name}</a>
</li>
));

return (
<ul className="sort-list grid-container">
{filterList}
</ul>
);


in the code sample above, we saw variable written in camel case, and underscore. There's not much technical issue. Just the variable naming inconsistencies. I just wondering if this small issue should be tackled or not.










share|improve this question

























  • "causing inconsistencies" isn't a concrete problem to which anyone could offer a solution. What actual issue is it giving you? Show some code and data which causes you a definable problem which someone could post a practical answer to. As for the naming convention question, that's purely a matter of opinion really.

    – ADyson
    Nov 14 '18 at 9:25













  • Is it common to convert the field names from API response? - it is. There are case conversion libs but they may be not needed if JSON response doesn't conform front end data structure. Unless back end was designed to take how data is used at front end into account, data structure may differ a lot.

    – estus
    Nov 14 '18 at 9:27














0












0








0








I'm working on a Front End system using ReactJS.



I'm following Airbnb javascript style guide.
But the API response from the Back End is using JSON with underscored variable names.



This causing inconsistencies in our codes. Are there any good solution for this? Is it common to convert the field names from API response? (i.e the JSON field 'product_id' will be converted to 'productId')



const { filter } = this.state;

const filterList = filter.list.map((item, index) => (
<li
key={index}
className={`border-bottom ${item.active ? 'active' : ''}`}
>
<a onClick={this.setFilter(item.product_id)}>{item.product_name}</a>
</li>
));

return (
<ul className="sort-list grid-container">
{filterList}
</ul>
);


in the code sample above, we saw variable written in camel case, and underscore. There's not much technical issue. Just the variable naming inconsistencies. I just wondering if this small issue should be tackled or not.










share|improve this question
















I'm working on a Front End system using ReactJS.



I'm following Airbnb javascript style guide.
But the API response from the Back End is using JSON with underscored variable names.



This causing inconsistencies in our codes. Are there any good solution for this? Is it common to convert the field names from API response? (i.e the JSON field 'product_id' will be converted to 'productId')



const { filter } = this.state;

const filterList = filter.list.map((item, index) => (
<li
key={index}
className={`border-bottom ${item.active ? 'active' : ''}`}
>
<a onClick={this.setFilter(item.product_id)}>{item.product_name}</a>
</li>
));

return (
<ul className="sort-list grid-container">
{filterList}
</ul>
);


in the code sample above, we saw variable written in camel case, and underscore. There's not much technical issue. Just the variable naming inconsistencies. I just wondering if this small issue should be tackled or not.







json reactjs variables naming-conventions






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 19 '18 at 14:00







Nando

















asked Nov 14 '18 at 9:14









NandoNando

112




112













  • "causing inconsistencies" isn't a concrete problem to which anyone could offer a solution. What actual issue is it giving you? Show some code and data which causes you a definable problem which someone could post a practical answer to. As for the naming convention question, that's purely a matter of opinion really.

    – ADyson
    Nov 14 '18 at 9:25













  • Is it common to convert the field names from API response? - it is. There are case conversion libs but they may be not needed if JSON response doesn't conform front end data structure. Unless back end was designed to take how data is used at front end into account, data structure may differ a lot.

    – estus
    Nov 14 '18 at 9:27



















  • "causing inconsistencies" isn't a concrete problem to which anyone could offer a solution. What actual issue is it giving you? Show some code and data which causes you a definable problem which someone could post a practical answer to. As for the naming convention question, that's purely a matter of opinion really.

    – ADyson
    Nov 14 '18 at 9:25













  • Is it common to convert the field names from API response? - it is. There are case conversion libs but they may be not needed if JSON response doesn't conform front end data structure. Unless back end was designed to take how data is used at front end into account, data structure may differ a lot.

    – estus
    Nov 14 '18 at 9:27

















"causing inconsistencies" isn't a concrete problem to which anyone could offer a solution. What actual issue is it giving you? Show some code and data which causes you a definable problem which someone could post a practical answer to. As for the naming convention question, that's purely a matter of opinion really.

– ADyson
Nov 14 '18 at 9:25







"causing inconsistencies" isn't a concrete problem to which anyone could offer a solution. What actual issue is it giving you? Show some code and data which causes you a definable problem which someone could post a practical answer to. As for the naming convention question, that's purely a matter of opinion really.

– ADyson
Nov 14 '18 at 9:25















Is it common to convert the field names from API response? - it is. There are case conversion libs but they may be not needed if JSON response doesn't conform front end data structure. Unless back end was designed to take how data is used at front end into account, data structure may differ a lot.

– estus
Nov 14 '18 at 9:27





Is it common to convert the field names from API response? - it is. There are case conversion libs but they may be not needed if JSON response doesn't conform front end data structure. Unless back end was designed to take how data is used at front end into account, data structure may differ a lot.

– estus
Nov 14 '18 at 9:27












0






active

oldest

votes











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53296581%2fvariable-naming-convention%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53296581%2fvariable-naming-convention%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

How to change which sound is reproduced for terminal bell?

Can I use Tabulator js library in my java Spring + Thymeleaf project?

Title Spacing in Bjornstrup Chapter, Removing Chapter Number From Contents