Laravel + Mockery InvalidCountException

I am trying to mock a class to prevent it from having to call 3rd party apis. But when setting up the mock, it doesn't seem to affect the controller action. I did try replacing the $this->postJson() by manually creating instances of the Request- and OEmbedController-classes. The create()-method is getting called, but I am receiving an error from Mockery that it isn't.

What am I doing wrong here?

Error:

MockeryExceptionInvalidCountException : Method create() from Mockery_2_Embed_Embed should be called exactly 1 times but called 0 times.

Test:

class OEmbedTest extends TestCase

{

    public function tearDown()

    {

        Mockery::close();

    }



    /**

     * It can return an OEmbed object

     * @test

     */

    public function it_can_return_an_o_embed_object()

    {

        $url = 'https://www.youtube.com/watch?v=9hUIxyE2Ns8';



        Mockery::mock(Embed::class)

            ->shouldReceive('create')

            ->with($url)

            ->once();



        $response = $this->postJson(route('oembed', ['url' => $url]));

        $response->assertSuccessful();

    }

}

Controller:

public function __invoke(Request $request)

{

    $info = Embed::create($request->url);



    $providers = $info->getProviders();



    $oembed = $providers['oembed'];



    return response()

        ->json($oembed

            ->getBag()

            ->getAll());

}

edited Nov 18 '18 at 14:23

asked Nov 18 '18 at 12:41

Fredrik

611324

You do not need to test the embed package; its already tested, right?
– Kyslik
Nov 18 '18 at 12:51

Yes, so my thoughts were to mock the response form that class.
– Fredrik
Nov 18 '18 at 12:54

A tip: you can rename the __invoke method to handle it'll look nicer. You are creating an instance of Embed within the (invoke) method; thats untestable without the mock. I personally avoid mocking anything and resort to stubs / fake classes etc. I do recommend letting the Laravel build / create / instantiate the Embed object before it hits the controller. Which means creating a service provider which will take care of the instantiating the Embed object for you and perhaps placing it in the $request itself. Do add more info about route you are accessing.
– Kyslik
Nov 18 '18 at 13:02

So you are basically saying I should dependency inject the class? Like $this->app->bind(). Sure that is possible, but shouldn't it be possible without that? Because then I need an Interface, etc, which feels cumbersome for this little test.
– Fredrik
Nov 18 '18 at 13:07

1

You do not need an interface, just use ->bind(EmbedEmbed::class, function($app){ return EmbedEmbed::create($app['request']->url); }); Now I do not know whats going on after create is called. But in the controller you can now use $info = resolve(EmbedEmbed::class); obviously you need to do checking if request has url parameter etc (do this within the bind closure). Now in the test setUp you need to rebind it, for more information read stackoverflow.com/questions/50262576/…
– Kyslik
Nov 18 '18 at 13:23

add a comment |

What am I doing wrong here?

Error:

MockeryExceptionInvalidCountException : Method create() from Mockery_2_Embed_Embed should be called exactly 1 times but called 0 times.

Test:

class OEmbedTest extends TestCase

{

    public function tearDown()

    {

        Mockery::close();

    }



    /**

     * It can return an OEmbed object

     * @test

     */

    public function it_can_return_an_o_embed_object()

    {

        $url = 'https://www.youtube.com/watch?v=9hUIxyE2Ns8';



        Mockery::mock(Embed::class)

            ->shouldReceive('create')

            ->with($url)

            ->once();



        $response = $this->postJson(route('oembed', ['url' => $url]));

        $response->assertSuccessful();

    }

}

Controller:

public function __invoke(Request $request)

{

    $info = Embed::create($request->url);



    $providers = $info->getProviders();



    $oembed = $providers['oembed'];



    return response()

        ->json($oembed

            ->getBag()

            ->getAll());

}

edited Nov 18 '18 at 14:23

asked Nov 18 '18 at 12:41

Fredrik

611324

You do not need to test the embed package; its already tested, right?
– Kyslik
Nov 18 '18 at 12:51

Yes, so my thoughts were to mock the response form that class.
– Fredrik
Nov 18 '18 at 12:54

A tip: you can rename the __invoke method to handle it'll look nicer. You are creating an instance of Embed within the (invoke) method; thats untestable without the mock. I personally avoid mocking anything and resort to stubs / fake classes etc. I do recommend letting the Laravel build / create / instantiate the Embed object before it hits the controller. Which means creating a service provider which will take care of the instantiating the Embed object for you and perhaps placing it in the $request itself. Do add more info about route you are accessing.
– Kyslik
Nov 18 '18 at 13:02

So you are basically saying I should dependency inject the class? Like $this->app->bind(). Sure that is possible, but shouldn't it be possible without that? Because then I need an Interface, etc, which feels cumbersome for this little test.
– Fredrik
Nov 18 '18 at 13:07

1

You do not need an interface, just use ->bind(EmbedEmbed::class, function($app){ return EmbedEmbed::create($app['request']->url); }); Now I do not know whats going on after create is called. But in the controller you can now use $info = resolve(EmbedEmbed::class); obviously you need to do checking if request has url parameter etc (do this within the bind closure). Now in the test setUp you need to rebind it, for more information read stackoverflow.com/questions/50262576/…
– Kyslik
Nov 18 '18 at 13:23

add a comment |

What am I doing wrong here?

Error:

MockeryExceptionInvalidCountException : Method create() from Mockery_2_Embed_Embed should be called exactly 1 times but called 0 times.

Test:

class OEmbedTest extends TestCase

{

    public function tearDown()

    {

        Mockery::close();

    }



    /**

     * It can return an OEmbed object

     * @test

     */

    public function it_can_return_an_o_embed_object()

    {

        $url = 'https://www.youtube.com/watch?v=9hUIxyE2Ns8';



        Mockery::mock(Embed::class)

            ->shouldReceive('create')

            ->with($url)

            ->once();



        $response = $this->postJson(route('oembed', ['url' => $url]));

        $response->assertSuccessful();

    }

}

Controller:

public function __invoke(Request $request)

{

    $info = Embed::create($request->url);



    $providers = $info->getProviders();



    $oembed = $providers['oembed'];



    return response()

        ->json($oembed

            ->getBag()

            ->getAll());

}

edited Nov 18 '18 at 14:23

asked Nov 18 '18 at 12:41

Fredrik

611324

What am I doing wrong here?

Error:

MockeryExceptionInvalidCountException : Method create() from Mockery_2_Embed_Embed should be called exactly 1 times but called 0 times.

Test:

class OEmbedTest extends TestCase

{

    public function tearDown()

    {

        Mockery::close();

    }



    /**

     * It can return an OEmbed object

     * @test

     */

    public function it_can_return_an_o_embed_object()

    {

        $url = 'https://www.youtube.com/watch?v=9hUIxyE2Ns8';



        Mockery::mock(Embed::class)

            ->shouldReceive('create')

            ->with($url)

            ->once();



        $response = $this->postJson(route('oembed', ['url' => $url]));

        $response->assertSuccessful();

    }

}

Controller:

public function __invoke(Request $request)

{

    $info = Embed::create($request->url);



    $providers = $info->getProviders();



    $oembed = $providers['oembed'];



    return response()

        ->json($oembed

            ->getBag()

            ->getAll());

}

laravel mockery

edited Nov 18 '18 at 14:23

asked Nov 18 '18 at 12:41

Fredrik

611324

edited Nov 18 '18 at 14:23

asked Nov 18 '18 at 12:41

Fredrik

611324

edited Nov 18 '18 at 14:23

asked Nov 18 '18 at 12:41

Fredrik

611324

asked Nov 18 '18 at 12:41

Fredrik

611324

asked Nov 18 '18 at 12:41

Fredrik

611324

You do not need to test the embed package; its already tested, right?
– Kyslik
Nov 18 '18 at 12:51

Yes, so my thoughts were to mock the response form that class.
– Fredrik
Nov 18 '18 at 12:54

A tip: you can rename the __invoke method to handle it'll look nicer. You are creating an instance of Embed within the (invoke) method; thats untestable without the mock. I personally avoid mocking anything and resort to stubs / fake classes etc. I do recommend letting the Laravel build / create / instantiate the Embed object before it hits the controller. Which means creating a service provider which will take care of the instantiating the Embed object for you and perhaps placing it in the $request itself. Do add more info about route you are accessing.
– Kyslik
Nov 18 '18 at 13:02

So you are basically saying I should dependency inject the class? Like $this->app->bind(). Sure that is possible, but shouldn't it be possible without that? Because then I need an Interface, etc, which feels cumbersome for this little test.
– Fredrik
Nov 18 '18 at 13:07

1

You do not need an interface, just use ->bind(EmbedEmbed::class, function($app){ return EmbedEmbed::create($app['request']->url); }); Now I do not know whats going on after create is called. But in the controller you can now use $info = resolve(EmbedEmbed::class); obviously you need to do checking if request has url parameter etc (do this within the bind closure). Now in the test setUp you need to rebind it, for more information read stackoverflow.com/questions/50262576/…
– Kyslik
Nov 18 '18 at 13:23

add a comment |

You do not need to test the embed package; its already tested, right?
– Kyslik
Nov 18 '18 at 12:51

Yes, so my thoughts were to mock the response form that class.
– Fredrik
Nov 18 '18 at 12:54

A tip: you can rename the __invoke method to handle it'll look nicer. You are creating an instance of Embed within the (invoke) method; thats untestable without the mock. I personally avoid mocking anything and resort to stubs / fake classes etc. I do recommend letting the Laravel build / create / instantiate the Embed object before it hits the controller. Which means creating a service provider which will take care of the instantiating the Embed object for you and perhaps placing it in the $request itself. Do add more info about route you are accessing.
– Kyslik
Nov 18 '18 at 13:02

So you are basically saying I should dependency inject the class? Like $this->app->bind(). Sure that is possible, but shouldn't it be possible without that? Because then I need an Interface, etc, which feels cumbersome for this little test.
– Fredrik
Nov 18 '18 at 13:07

1

You do not need an interface, just use ->bind(EmbedEmbed::class, function($app){ return EmbedEmbed::create($app['request']->url); }); Now I do not know whats going on after create is called. But in the controller you can now use $info = resolve(EmbedEmbed::class); obviously you need to do checking if request has url parameter etc (do this within the bind closure). Now in the test setUp you need to rebind it, for more information read stackoverflow.com/questions/50262576/…
– Kyslik
Nov 18 '18 at 13:23

You do not need to test the embed package; its already tested, right?
– Kyslik
Nov 18 '18 at 12:51

Yes, so my thoughts were to mock the response form that class.
– Fredrik
Nov 18 '18 at 12:54

A tip: you can rename the __invoke method to handle it'll look nicer. You are creating an instance of Embed within the (invoke) method; thats untestable without the mock. I personally avoid mocking anything and resort to stubs / fake classes etc. I do recommend letting the Laravel build / create / instantiate the Embed object before it hits the controller. Which means creating a service provider which will take care of the instantiating the Embed object for you and perhaps placing it in the $request itself. Do add more info about route you are accessing.
– Kyslik
Nov 18 '18 at 13:02

So you are basically saying I should dependency inject the class? Like $this->app->bind(). Sure that is possible, but shouldn't it be possible without that? Because then I need an Interface, etc, which feels cumbersome for this little test.
– Fredrik
Nov 18 '18 at 13:07

You do not need an interface, just use ->bind(EmbedEmbed::class, function($app){ return EmbedEmbed::create($app['request']->url); }); Now I do not know whats going on after create is called. But in the controller you can now use $info = resolve(EmbedEmbed::class); obviously you need to do checking if request has url parameter etc (do this within the bind closure). Now in the test setUp you need to rebind it, for more information read stackoverflow.com/questions/50262576/…
– Kyslik
Nov 18 '18 at 13:23

add a comment |

2 Answers
2

active

oldest

votes

It seems you are mocking the Embed class the wrong way. If you use the Laravel facade method shouldReceive() instead of creating a Mock of the class itself, the framework will place the mock in the service container for you:

Embed::shouldReceive('create')

    ->with($url)

    ->once();

instead of

Mockery::mock(Embed::class)

    ->shouldReceive('create')

    ->with($url)

    ->once();

Also be aware that if the parameters your tested code passes to the mock differs from what you learned the mock with with($url), the mock considers itself uncalled. But you'll receive another error for calling a not defined method anyway.

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

The Embed class isn't a Facade though. Its namespace is EmbedEmbed.
– Fredrik
Nov 18 '18 at 13:30

So you are trying to mock a static method? I'm afraid that's not going to work.
– Namoshek
Nov 18 '18 at 13:31

Didn't know you can't mock static methods without using Facades.
– Fredrik
Nov 18 '18 at 13:33

That's actually a limitation of the mocking libraries, not Laravel. Facades only provide static access to methods; it doesn't mean the methods itself are static (in fact, they are never as far as I know). So the easiest way to achieve testability could be to build your own proxy class around it... (which doesn't use static methods).
– Namoshek
Nov 18 '18 at 13:37

add a comment |

I was able to solve this by using this in my test:

protected function setUp()

{

    parent::setUp();



    app()->instance(Embed::class, new FakeEmbed);

}

Then resolving it like this

$embed = resolve(Embed::class);

$embed = $embed->create($url);

answered Nov 18 '18 at 14:25

Fredrik

611324

add a comment |

Your Answer

StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});

}
});

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53360987%2flaravel-mockery-invalidcountexception%23new-answer', 'question_page');
}
);

Post as a guest

Name

Required, but never shown

2 Answers
2

active

oldest

votes

2 Answers
2

active

oldest

votes

Embed::shouldReceive('create')

    ->with($url)

    ->once();

instead of

Mockery::mock(Embed::class)

    ->shouldReceive('create')

    ->with($url)

    ->once();

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

The Embed class isn't a Facade though. Its namespace is EmbedEmbed.
– Fredrik
Nov 18 '18 at 13:30

So you are trying to mock a static method? I'm afraid that's not going to work.
– Namoshek
Nov 18 '18 at 13:31

Didn't know you can't mock static methods without using Facades.
– Fredrik
Nov 18 '18 at 13:33

That's actually a limitation of the mocking libraries, not Laravel. Facades only provide static access to methods; it doesn't mean the methods itself are static (in fact, they are never as far as I know). So the easiest way to achieve testability could be to build your own proxy class around it... (which doesn't use static methods).
– Namoshek
Nov 18 '18 at 13:37

add a comment |

Embed::shouldReceive('create')

    ->with($url)

    ->once();

instead of

Mockery::mock(Embed::class)

    ->shouldReceive('create')

    ->with($url)

    ->once();

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

The Embed class isn't a Facade though. Its namespace is EmbedEmbed.
– Fredrik
Nov 18 '18 at 13:30

So you are trying to mock a static method? I'm afraid that's not going to work.
– Namoshek
Nov 18 '18 at 13:31

Didn't know you can't mock static methods without using Facades.
– Fredrik
Nov 18 '18 at 13:33

That's actually a limitation of the mocking libraries, not Laravel. Facades only provide static access to methods; it doesn't mean the methods itself are static (in fact, they are never as far as I know). So the easiest way to achieve testability could be to build your own proxy class around it... (which doesn't use static methods).
– Namoshek
Nov 18 '18 at 13:37

add a comment |

Embed::shouldReceive('create')

    ->with($url)

    ->once();

instead of

Mockery::mock(Embed::class)

    ->shouldReceive('create')

    ->with($url)

    ->once();

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

Embed::shouldReceive('create')

    ->with($url)

    ->once();

instead of

Mockery::mock(Embed::class)

    ->shouldReceive('create')

    ->with($url)

    ->once();

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

answered Nov 18 '18 at 13:24

Namoshek

2,9362719

The Embed class isn't a Facade though. Its namespace is EmbedEmbed.
– Fredrik
Nov 18 '18 at 13:30

So you are trying to mock a static method? I'm afraid that's not going to work.
– Namoshek
Nov 18 '18 at 13:31

Didn't know you can't mock static methods without using Facades.
– Fredrik
Nov 18 '18 at 13:33

That's actually a limitation of the mocking libraries, not Laravel. Facades only provide static access to methods; it doesn't mean the methods itself are static (in fact, they are never as far as I know). So the easiest way to achieve testability could be to build your own proxy class around it... (which doesn't use static methods).
– Namoshek
Nov 18 '18 at 13:37

add a comment |

The Embed class isn't a Facade though. Its namespace is EmbedEmbed.
– Fredrik
Nov 18 '18 at 13:30

So you are trying to mock a static method? I'm afraid that's not going to work.
– Namoshek
Nov 18 '18 at 13:31

Didn't know you can't mock static methods without using Facades.
– Fredrik
Nov 18 '18 at 13:33

That's actually a limitation of the mocking libraries, not Laravel. Facades only provide static access to methods; it doesn't mean the methods itself are static (in fact, they are never as far as I know). So the easiest way to achieve testability could be to build your own proxy class around it... (which doesn't use static methods).
– Namoshek
Nov 18 '18 at 13:37

The Embed class isn't a Facade though. Its namespace is EmbedEmbed.
– Fredrik
Nov 18 '18 at 13:30

So you are trying to mock a static method? I'm afraid that's not going to work.
– Namoshek
Nov 18 '18 at 13:31

Didn't know you can't mock static methods without using Facades.
– Fredrik
Nov 18 '18 at 13:33

That's actually a limitation of the mocking libraries, not Laravel. Facades only provide static access to methods; it doesn't mean the methods itself are static (in fact, they are never as far as I know). So the easiest way to achieve testability could be to build your own proxy class around it... (which doesn't use static methods).
– Namoshek
Nov 18 '18 at 13:37

add a comment |

I was able to solve this by using this in my test:

protected function setUp()

{

    parent::setUp();



    app()->instance(Embed::class, new FakeEmbed);

}

Then resolving it like this

$embed = resolve(Embed::class);

$embed = $embed->create($url);

answered Nov 18 '18 at 14:25

Fredrik

611324

add a comment |

I was able to solve this by using this in my test:

protected function setUp()

{

    parent::setUp();



    app()->instance(Embed::class, new FakeEmbed);

}

Then resolving it like this

$embed = resolve(Embed::class);

$embed = $embed->create($url);

answered Nov 18 '18 at 14:25

Fredrik

611324

add a comment |

I was able to solve this by using this in my test:

protected function setUp()

{

    parent::setUp();



    app()->instance(Embed::class, new FakeEmbed);

}

Then resolving it like this

$embed = resolve(Embed::class);

$embed = $embed->create($url);

answered Nov 18 '18 at 14:25

Fredrik

611324

I was able to solve this by using this in my test:

protected function setUp()

{

    parent::setUp();



    app()->instance(Embed::class, new FakeEmbed);

}

Then resolving it like this

$embed = resolve(Embed::class);

$embed = $embed->create($url);

answered Nov 18 '18 at 14:25

Fredrik

611324

answered Nov 18 '18 at 14:25

Fredrik

611324

answered Nov 18 '18 at 14:25

Fredrik

611324

answered Nov 18 '18 at 14:25

Fredrik

611324

add a comment |

draft saved

draft discarded

Thanks for contributing an answer to Stack Overflow!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

Some of your past answers have not been well-received, and you're in danger of being blocked from answering.

Please pay close attention to the following guidance:

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Sign up or log in

StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Cfrgtkky