TYPO3 old extension update using 'exit': good or not?
Some years ago I developed an extension as backend module. It can run on TYPO3 7 LTS. Recently I updated it and want to let it run on TYPO3 8 LTS.
It is not based on Extbase, the main class path is mod1/index.php.
In this index.php there is the main class tx_xxxxx_module1. In the class tx_xxxxxx_module1 there are multiple functions, which can generate wished contents. At the end of the index.php a function is called to print the content (into an iframe): $SOBE->printContent();
//index.php
<?php
global $MCONF;
require_once TYPO3CMSCoreUtilityExtensionManagementUtility::extPath('xxxxx').'mod1/conf.php';
class tx_xxxxx_module1 extends TYPO3CMSBackendModuleBaseScriptClass {
......
function main() {
......
}
......
function printContent() {
......
}
}
......
$SOBE = TYPO3CMSCoreUtilityGeneralUtility::makeInstance('tx_xxxxx_module1');
$SOBE->main();
$SOBE->printContent();
?>
Here $SOBE is an instance (singleton) of the class tx_xxxxxx_module1; in the function printContent() there is nothing other than an echo command:
function printContent()
{
echo $this->content;
}
This works well for TYPO3 7. But in TYPO3 8, I saw nothing in the iframe. So I added an exit command in the function printContent(). Problem solved! The content appeared in the iframe!
function printContent()
{
echo $this->content;
exit;
}
My question: is this workaround (using exit) good or not? Are there any other better or recommended approaches to doing it?
debugging typo3 typo3-8.x
edited Nov 16 '18 at 19:34
Peter Kraume
643313
asked Nov 16 '18 at 12:46
nweicp
344
add a comment |
Some years ago I developed an extension as backend module. It can run on TYPO3 7 LTS. Recently I updated it and want to let it run on TYPO3 8 LTS.
It is not based on Extbase, the main class path is mod1/index.php.
In this index.php there is the main class tx_xxxxx_module1. In the class tx_xxxxxx_module1 there are multiple functions, which can generate wished contents. At the end of the index.php a function is called to print the content (into an iframe): $SOBE->printContent();
//index.php
<?php
global $MCONF;
require_once TYPO3CMSCoreUtilityExtensionManagementUtility::extPath('xxxxx').'mod1/conf.php';
class tx_xxxxx_module1 extends TYPO3CMSBackendModuleBaseScriptClass {
......
function main() {
......
}
......
function printContent() {
......
}
}
......
$SOBE = TYPO3CMSCoreUtilityGeneralUtility::makeInstance('tx_xxxxx_module1');
$SOBE->main();
$SOBE->printContent();
?>
Here $SOBE is an instance (singleton) of the class tx_xxxxxx_module1; in the function printContent() there is nothing other than an echo command:
function printContent()
{
echo $this->content;
}
This works well for TYPO3 7. But in TYPO3 8, I saw nothing in the iframe. So I added an exit command in the function printContent(). Problem solved! The content appeared in the iframe!
function printContent()
{
echo $this->content;
exit;
}
My question: is this workaround (using exit) good or not? Are there any other better or recommended approaches to doing it?
debugging typo3 typo3-8.x
edited Nov 16 '18 at 19:34
Peter Kraume
643313
asked Nov 16 '18 at 12:46
nweicp
344
add a comment |
Some years ago I developed an extension as backend module. It can run on TYPO3 7 LTS. Recently I updated it and want to let it run on TYPO3 8 LTS.
It is not based on Extbase, the main class path is mod1/index.php.
In this index.php there is the main class tx_xxxxx_module1. In the class tx_xxxxxx_module1 there are multiple functions, which can generate wished contents. At the end of the index.php a function is called to print the content (into an iframe): $SOBE->printContent();
//index.php
<?php
global $MCONF;
require_once TYPO3CMSCoreUtilityExtensionManagementUtility::extPath('xxxxx').'mod1/conf.php';
class tx_xxxxx_module1 extends TYPO3CMSBackendModuleBaseScriptClass {
......
function main() {
......
}
......
function printContent() {
......
}
}
......
$SOBE = TYPO3CMSCoreUtilityGeneralUtility::makeInstance('tx_xxxxx_module1');
$SOBE->main();
$SOBE->printContent();
?>
Here $SOBE is an instance (singleton) of the class tx_xxxxxx_module1; in the function printContent() there is nothing other than an echo command:
function printContent()
{
echo $this->content;
}
This works well for TYPO3 7. But in TYPO3 8, I saw nothing in the iframe. So I added an exit command in the function printContent(). Problem solved! The content appeared in the iframe!
function printContent()
{
echo $this->content;
exit;
}
My question: is this workaround (using exit) good or not? Are there any other better or recommended approaches to doing it?
debugging typo3 typo3-8.x
edited Nov 16 '18 at 19:34
Peter Kraume
643313
asked Nov 16 '18 at 12:46
nweicp
344
Some years ago I developed an extension as backend module. It can run on TYPO3 7 LTS. Recently I updated it and want to let it run on TYPO3 8 LTS.
It is not based on Extbase, the main class path is mod1/index.php.
In this index.php there is the main class tx_xxxxx_module1. In the class tx_xxxxxx_module1 there are multiple functions, which can generate wished contents. At the end of the index.php a function is called to print the content (into an iframe): $SOBE->printContent();
//index.php
<?php
global $MCONF;
require_once TYPO3CMSCoreUtilityExtensionManagementUtility::extPath('xxxxx').'mod1/conf.php';
class tx_xxxxx_module1 extends TYPO3CMSBackendModuleBaseScriptClass {
......
function main() {
......
}
......
function printContent() {
......
}
}
......
$SOBE = TYPO3CMSCoreUtilityGeneralUtility::makeInstance('tx_xxxxx_module1');
$SOBE->main();
$SOBE->printContent();
?>
Here $SOBE is an instance (singleton) of the class tx_xxxxxx_module1; in the function printContent() there is nothing other than an echo command:
function printContent()
{
echo $this->content;
}
This works well for TYPO3 7. But in TYPO3 8, I saw nothing in the iframe. So I added an exit command in the function printContent(). Problem solved! The content appeared in the iframe!
function printContent()
{
echo $this->content;
exit;
}
My question: is this workaround (using exit) good or not? Are there any other better or recommended approaches to doing it?
debugging typo3 typo3-8.x
debugging typo3 typo3-8.x
edited Nov 16 '18 at 19:34
Peter Kraume
643313
asked Nov 16 '18 at 12:46
nweicp
344
edited Nov 16 '18 at 19:34
Peter Kraume
643313
asked Nov 16 '18 at 12:46
nweicp
344
edited Nov 16 '18 at 19:34
Peter Kraume
643313
edited Nov 16 '18 at 19:34
Peter Kraume
643313
edited Nov 16 '18 at 19:34
Peter Kraume
643313
643313
asked Nov 16 '18 at 12:46
nweicp
344
asked Nov 16 '18 at 12:46
nweicp
344
asked Nov 16 '18 at 12:46
nweicp
344
344
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
This sounds ok but I would think about refactoring the code in total if you need that, also switch to fluid for templating and so on. however there is no need to switch to extbase if you don't need it.
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53338212%2ftypo3-old-extension-update-using-exit-good-or-not%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
This sounds ok but I would think about refactoring the code in total if you need that, also switch to fluid for templating and so on. however there is no need to switch to extbase if you don't need it.
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
add a comment |
This sounds ok but I would think about refactoring the code in total if you need that, also switch to fluid for templating and so on. however there is no need to switch to extbase if you don't need it.
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
add a comment |
This sounds ok but I would think about refactoring the code in total if you need that, also switch to fluid for templating and so on. however there is no need to switch to extbase if you don't need it.
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
This sounds ok but I would think about refactoring the code in total if you need that, also switch to fluid for templating and so on. however there is no need to switch to extbase if you don't need it.
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
answered Nov 17 '18 at 18:30
Georg Ringer
4,8821927
4,8821927
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53338212%2ftypo3-old-extension-update-using-exit-good-or-not%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
