Cfrgtkky

I have a list of files which I need to delete from multiple years' worth of monthly file archives.
there are about 400+ file names in a text file, and about 5 years of monthly archives, sorted into folders by year.

my script does a double loop, looking for each file in each archive and deleting it, but it's insaaaanely slow.
I'm looking for any suggestions of what I can do to improve my approach. thanks!

set-alias rar "C:Program Files7-Zip7z.exe"



    $archives = get-childitem 'D:Archive DataAPP_PwebsiteDocumentexportsExports ArchiveArchive2014exports'   -Recurse

    write-host $archives

    Get-Alias rar



    foreach ($archive in $archives ) {



    write-host $archive.Mode



    $exports = Get-Content C:scriptsScottTrade_cleanup.txt.txt

        foreach ($export in $exports){

        write-host $export

       rar d $archive.FullName $export -r



        }



    } 

So you have a minor performance issue with

$exports = Get-Content C:scriptsScottTrade_cleanup.txt.txt

Move that outside the loops

The big problem is that you are reloading a zip for every file you are seeking to delete. We need to fix this. Take your file that is a list of files, get rid of the inner loop and run this:

rar d $archive.FullName -r @FullListFilePathNameExtension

My first solution was to use the include switch (-i) with the delete, but Windows doesn't support command line over 8k.