unit testing my angular material data table with an expansion panel either does not run or detect finish of...












2















I have a large reusable component that wraps up the material data table. My problem is that my unit tests need to check the logic that allows the wrapper to set the initial state of each expansion row(open / closed) and I cannot tell if the click event is running or if fixture.whenRenderingDone is not actually waiting for aniamtions to finish as the height of the clicked row always has a height of 0px, its initial height.



My @component annotation looks like this:



@Component({
selector: '',
templateUrl: './.html',
styleUrls: ['./scss'],
animations: [
trigger('detailExpand', [
state('collapsed', style({ height: '0px', minHeight: '0', display: 'none' })),
state('expanded', style({ height: '*' })),
transition('expanded <=> collapsed', animate('225ms cubic-bezier(0.4, 0.0, 0.2, 1)')),
]),
],
})


This is standard lifted from the angular docs (removed some file names).



My HTML matching this to produce the data table is:



<ng-container *ngIf="hasExpansionPanel">
<mat-row *matRowDef="let row; columns: ['expandedDetail']" class="expansion-row no-padding" [@detailExpand]="row == expandedRow || expandAllPanels ? 'expanded' : 'collapsed'"></mat-row>
</ng-container>


The test:



   it('should be able to display a nested table', () => {
fixture.whenStable().then(() => {
const standardRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.standard-row');
const firstRow: HTMLElement = standardRows[0];

const expansionRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.expansion-row');
const firstExpansionRow: HTMLElement = expansionRows[1];
const originalPanelRowHeight = firstExpansionRow.clientHeight;

clickEvent(firstRow);
fixture.detectChanges();

fixture.whenRenderingDone().then(() => {
// animation
expect(originalPanelRowHeight).toBe(0);
expect(firstExpansionRow.clientHeight).toBeGreaterThan(0);

});
});
});


Some supporting code the test uses:



/**
* Create custom DOM event the old fashioned way
*
* https://developer.mozilla.org/en-US/docs/Web/API/Event/initEvent
* Although officially deprecated, some browsers (phantom) don't accept the preferred "new Event(eventName)"
*/
export function newEvent(eventName: string, bubbles = false, cancelable = false) {
const evt = document.createEvent('CustomEvent'); // MUST be 'CustomEvent'
evt.initCustomEvent(eventName, bubbles, cancelable, null);
return evt;
}

export function clickEvent(ele: Element): void {
ele.dispatchEvent(newEvent('click'));
}









share|improve this question



























    2















    I have a large reusable component that wraps up the material data table. My problem is that my unit tests need to check the logic that allows the wrapper to set the initial state of each expansion row(open / closed) and I cannot tell if the click event is running or if fixture.whenRenderingDone is not actually waiting for aniamtions to finish as the height of the clicked row always has a height of 0px, its initial height.



    My @component annotation looks like this:



    @Component({
    selector: '',
    templateUrl: './.html',
    styleUrls: ['./scss'],
    animations: [
    trigger('detailExpand', [
    state('collapsed', style({ height: '0px', minHeight: '0', display: 'none' })),
    state('expanded', style({ height: '*' })),
    transition('expanded <=> collapsed', animate('225ms cubic-bezier(0.4, 0.0, 0.2, 1)')),
    ]),
    ],
    })


    This is standard lifted from the angular docs (removed some file names).



    My HTML matching this to produce the data table is:



    <ng-container *ngIf="hasExpansionPanel">
    <mat-row *matRowDef="let row; columns: ['expandedDetail']" class="expansion-row no-padding" [@detailExpand]="row == expandedRow || expandAllPanels ? 'expanded' : 'collapsed'"></mat-row>
    </ng-container>


    The test:



       it('should be able to display a nested table', () => {
    fixture.whenStable().then(() => {
    const standardRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.standard-row');
    const firstRow: HTMLElement = standardRows[0];

    const expansionRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.expansion-row');
    const firstExpansionRow: HTMLElement = expansionRows[1];
    const originalPanelRowHeight = firstExpansionRow.clientHeight;

    clickEvent(firstRow);
    fixture.detectChanges();

    fixture.whenRenderingDone().then(() => {
    // animation
    expect(originalPanelRowHeight).toBe(0);
    expect(firstExpansionRow.clientHeight).toBeGreaterThan(0);

    });
    });
    });


    Some supporting code the test uses:



    /**
    * Create custom DOM event the old fashioned way
    *
    * https://developer.mozilla.org/en-US/docs/Web/API/Event/initEvent
    * Although officially deprecated, some browsers (phantom) don't accept the preferred "new Event(eventName)"
    */
    export function newEvent(eventName: string, bubbles = false, cancelable = false) {
    const evt = document.createEvent('CustomEvent'); // MUST be 'CustomEvent'
    evt.initCustomEvent(eventName, bubbles, cancelable, null);
    return evt;
    }

    export function clickEvent(ele: Element): void {
    ele.dispatchEvent(newEvent('click'));
    }









    share|improve this question

























      2












      2








      2








      I have a large reusable component that wraps up the material data table. My problem is that my unit tests need to check the logic that allows the wrapper to set the initial state of each expansion row(open / closed) and I cannot tell if the click event is running or if fixture.whenRenderingDone is not actually waiting for aniamtions to finish as the height of the clicked row always has a height of 0px, its initial height.



      My @component annotation looks like this:



      @Component({
      selector: '',
      templateUrl: './.html',
      styleUrls: ['./scss'],
      animations: [
      trigger('detailExpand', [
      state('collapsed', style({ height: '0px', minHeight: '0', display: 'none' })),
      state('expanded', style({ height: '*' })),
      transition('expanded <=> collapsed', animate('225ms cubic-bezier(0.4, 0.0, 0.2, 1)')),
      ]),
      ],
      })


      This is standard lifted from the angular docs (removed some file names).



      My HTML matching this to produce the data table is:



      <ng-container *ngIf="hasExpansionPanel">
      <mat-row *matRowDef="let row; columns: ['expandedDetail']" class="expansion-row no-padding" [@detailExpand]="row == expandedRow || expandAllPanels ? 'expanded' : 'collapsed'"></mat-row>
      </ng-container>


      The test:



         it('should be able to display a nested table', () => {
      fixture.whenStable().then(() => {
      const standardRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.standard-row');
      const firstRow: HTMLElement = standardRows[0];

      const expansionRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.expansion-row');
      const firstExpansionRow: HTMLElement = expansionRows[1];
      const originalPanelRowHeight = firstExpansionRow.clientHeight;

      clickEvent(firstRow);
      fixture.detectChanges();

      fixture.whenRenderingDone().then(() => {
      // animation
      expect(originalPanelRowHeight).toBe(0);
      expect(firstExpansionRow.clientHeight).toBeGreaterThan(0);

      });
      });
      });


      Some supporting code the test uses:



      /**
      * Create custom DOM event the old fashioned way
      *
      * https://developer.mozilla.org/en-US/docs/Web/API/Event/initEvent
      * Although officially deprecated, some browsers (phantom) don't accept the preferred "new Event(eventName)"
      */
      export function newEvent(eventName: string, bubbles = false, cancelable = false) {
      const evt = document.createEvent('CustomEvent'); // MUST be 'CustomEvent'
      evt.initCustomEvent(eventName, bubbles, cancelable, null);
      return evt;
      }

      export function clickEvent(ele: Element): void {
      ele.dispatchEvent(newEvent('click'));
      }









      share|improve this question














      I have a large reusable component that wraps up the material data table. My problem is that my unit tests need to check the logic that allows the wrapper to set the initial state of each expansion row(open / closed) and I cannot tell if the click event is running or if fixture.whenRenderingDone is not actually waiting for aniamtions to finish as the height of the clicked row always has a height of 0px, its initial height.



      My @component annotation looks like this:



      @Component({
      selector: '',
      templateUrl: './.html',
      styleUrls: ['./scss'],
      animations: [
      trigger('detailExpand', [
      state('collapsed', style({ height: '0px', minHeight: '0', display: 'none' })),
      state('expanded', style({ height: '*' })),
      transition('expanded <=> collapsed', animate('225ms cubic-bezier(0.4, 0.0, 0.2, 1)')),
      ]),
      ],
      })


      This is standard lifted from the angular docs (removed some file names).



      My HTML matching this to produce the data table is:



      <ng-container *ngIf="hasExpansionPanel">
      <mat-row *matRowDef="let row; columns: ['expandedDetail']" class="expansion-row no-padding" [@detailExpand]="row == expandedRow || expandAllPanels ? 'expanded' : 'collapsed'"></mat-row>
      </ng-container>


      The test:



         it('should be able to display a nested table', () => {
      fixture.whenStable().then(() => {
      const standardRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.standard-row');
      const firstRow: HTMLElement = standardRows[0];

      const expansionRows: NodeListOf<HTMLElement> = fixture.nativeElement.querySelectorAll('.expansion-row');
      const firstExpansionRow: HTMLElement = expansionRows[1];
      const originalPanelRowHeight = firstExpansionRow.clientHeight;

      clickEvent(firstRow);
      fixture.detectChanges();

      fixture.whenRenderingDone().then(() => {
      // animation
      expect(originalPanelRowHeight).toBe(0);
      expect(firstExpansionRow.clientHeight).toBeGreaterThan(0);

      });
      });
      });


      Some supporting code the test uses:



      /**
      * Create custom DOM event the old fashioned way
      *
      * https://developer.mozilla.org/en-US/docs/Web/API/Event/initEvent
      * Although officially deprecated, some browsers (phantom) don't accept the preferred "new Event(eventName)"
      */
      export function newEvent(eventName: string, bubbles = false, cancelable = false) {
      const evt = document.createEvent('CustomEvent'); // MUST be 'CustomEvent'
      evt.initCustomEvent(eventName, bubbles, cancelable, null);
      return evt;
      }

      export function clickEvent(ele: Element): void {
      ele.dispatchEvent(newEvent('click'));
      }






      angular unit-testing karma-jasmine angular-material2






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 21 '18 at 16:43









      CraigCraig

      400215




      400215
























          0






          active

          oldest

          votes











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53416821%2funit-testing-my-angular-material-data-table-with-an-expansion-panel-either-does%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes
















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53416821%2funit-testing-my-angular-material-data-table-with-an-expansion-panel-either-does%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Biblatex bibliography style without URLs when DOI exists (in Overleaf with Zotero bibliography)

          ComboBox Display Member on multiple fields

          Is it possible to collect Nectar points via Trainline?