How to access private members of a class from it's private constructor
I have following class and here i'm trying to access private members of the class from private constructor.
class House {
private:
int len;
int wid;
House()
{
}
public:
~House()
{
std::cout << "destructor call" << std::endl;
}
static std::shared_ptr<House> house;
static auto getHouse(const int length, const int width);
void setlen(int lenth) { len = lenth; }
void setwid(int width) { wid = width; }
int getlen() { return len; }
int getwid() { return wid; }
};
auto House::getHouse(const int length, const int width)
{
House::house = std::make_shared<House>();
if ((House::house->getlen()==length) && (House::house->getwid()== width))
{
return House::house;
}
else
{
House::house->setlen(length);
House::house->setwid(width);
return House::house;
}
}
I get the following error message
Severity Code Description Project File Line Suppression State
Error C2248 'House::House': cannot access private member declared in class 'House' TestC++ c:program files (x86)microsoft visual studio2017communityvctoolsmsvc14.14.26428includememory 1770
c++ function constructor private smart-pointers
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
|
show 1 more comment
I have following class and here i'm trying to access private members of the class from private constructor.
class House {
private:
int len;
int wid;
House()
{
}
public:
~House()
{
std::cout << "destructor call" << std::endl;
}
static std::shared_ptr<House> house;
static auto getHouse(const int length, const int width);
void setlen(int lenth) { len = lenth; }
void setwid(int width) { wid = width; }
int getlen() { return len; }
int getwid() { return wid; }
};
auto House::getHouse(const int length, const int width)
{
House::house = std::make_shared<House>();
if ((House::house->getlen()==length) && (House::house->getwid()== width))
{
return House::house;
}
else
{
House::house->setlen(length);
House::house->setwid(width);
return House::house;
}
}
I get the following error message
Severity Code Description Project File Line Suppression State
Error C2248 'House::House': cannot access private member declared in class 'House' TestC++ c:program files (x86)microsoft visual studio2017communityvctoolsmsvc14.14.26428includememory 1770
c++ function constructor private smart-pointers
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
May be the error messages from this MCVE are clearer.
– πάντα ῥεῖ
Nov 20 '18 at 18:09
The majority of the code you've posted is not relevant to the actual problem. Why do you thinkmake_sharedshould be able to call a private constructor?
– Praetorian
Nov 20 '18 at 18:10
@πάνταῥεῖ Clearly clarity is in the eye of the beholder!
– TypeIA
Nov 20 '18 at 18:12
See stackoverflow.com/q/8147027/241631
– Praetorian
Nov 20 '18 at 18:13
@Praetorian here i'm trying to construct the object withing a class and use outside the class using smart pointers problem is clear with shared_ptr here.
– Ruchira
Nov 20 '18 at 18:32
|
show 1 more comment
I have following class and here i'm trying to access private members of the class from private constructor.
class House {
private:
int len;
int wid;
House()
{
}
public:
~House()
{
std::cout << "destructor call" << std::endl;
}
static std::shared_ptr<House> house;
static auto getHouse(const int length, const int width);
void setlen(int lenth) { len = lenth; }
void setwid(int width) { wid = width; }
int getlen() { return len; }
int getwid() { return wid; }
};
auto House::getHouse(const int length, const int width)
{
House::house = std::make_shared<House>();
if ((House::house->getlen()==length) && (House::house->getwid()== width))
{
return House::house;
}
else
{
House::house->setlen(length);
House::house->setwid(width);
return House::house;
}
}
I get the following error message
Severity Code Description Project File Line Suppression State
Error C2248 'House::House': cannot access private member declared in class 'House' TestC++ c:program files (x86)microsoft visual studio2017communityvctoolsmsvc14.14.26428includememory 1770
c++ function constructor private smart-pointers
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
I have following class and here i'm trying to access private members of the class from private constructor.
class House {
private:
int len;
int wid;
House()
{
}
public:
~House()
{
std::cout << "destructor call" << std::endl;
}
static std::shared_ptr<House> house;
static auto getHouse(const int length, const int width);
void setlen(int lenth) { len = lenth; }
void setwid(int width) { wid = width; }
int getlen() { return len; }
int getwid() { return wid; }
};
auto House::getHouse(const int length, const int width)
{
House::house = std::make_shared<House>();
if ((House::house->getlen()==length) && (House::house->getwid()== width))
{
return House::house;
}
else
{
House::house->setlen(length);
House::house->setwid(width);
return House::house;
}
}
I get the following error message
Severity Code Description Project File Line Suppression State
Error C2248 'House::House': cannot access private member declared in class 'House' TestC++ c:program files (x86)microsoft visual studio2017communityvctoolsmsvc14.14.26428includememory 1770
c++ function constructor private smart-pointers
c++ function constructor private smart-pointers
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
edited Nov 20 '18 at 18:11
Ruchira
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
asked Nov 20 '18 at 18:03
RuchiraRuchira
34
34
May be the error messages from this MCVE are clearer.
– πάντα ῥεῖ
Nov 20 '18 at 18:09
The majority of the code you've posted is not relevant to the actual problem. Why do you thinkmake_sharedshould be able to call a private constructor?
– Praetorian
Nov 20 '18 at 18:10
@πάνταῥεῖ Clearly clarity is in the eye of the beholder!
– TypeIA
Nov 20 '18 at 18:12
See stackoverflow.com/q/8147027/241631
– Praetorian
Nov 20 '18 at 18:13
@Praetorian here i'm trying to construct the object withing a class and use outside the class using smart pointers problem is clear with shared_ptr here.
– Ruchira
Nov 20 '18 at 18:32
|
show 1 more comment
May be the error messages from this MCVE are clearer.
– πάντα ῥεῖ
Nov 20 '18 at 18:09
The majority of the code you've posted is not relevant to the actual problem. Why do you thinkmake_sharedshould be able to call a private constructor?
– Praetorian
Nov 20 '18 at 18:10
@πάνταῥεῖ Clearly clarity is in the eye of the beholder!
– TypeIA
Nov 20 '18 at 18:12
See stackoverflow.com/q/8147027/241631
– Praetorian
Nov 20 '18 at 18:13
@Praetorian here i'm trying to construct the object withing a class and use outside the class using smart pointers problem is clear with shared_ptr here.
– Ruchira
Nov 20 '18 at 18:32
May be the error messages from this MCVE are clearer.
– πάντα ῥεῖ
Nov 20 '18 at 18:09
May be the error messages from this MCVE are clearer.
– πάντα ῥεῖ
Nov 20 '18 at 18:09
The majority of the code you've posted is not relevant to the actual problem. Why do you think
make_shared should be able to call a private constructor?– Praetorian
Nov 20 '18 at 18:10
The majority of the code you've posted is not relevant to the actual problem. Why do you think
make_shared should be able to call a private constructor?– Praetorian
Nov 20 '18 at 18:10
@πάνταῥεῖ Clearly clarity is in the eye of the beholder!
– TypeIA
Nov 20 '18 at 18:12
@πάνταῥεῖ Clearly clarity is in the eye of the beholder!
– TypeIA
Nov 20 '18 at 18:12
See stackoverflow.com/q/8147027/241631
– Praetorian
Nov 20 '18 at 18:13
See stackoverflow.com/q/8147027/241631
– Praetorian
Nov 20 '18 at 18:13
@Praetorian here i'm trying to construct the object withing a class and use outside the class using smart pointers problem is clear with shared_ptr here.
– Ruchira
Nov 20 '18 at 18:32
@Praetorian here i'm trying to construct the object withing a class and use outside the class using smart pointers problem is clear with shared_ptr here.
– Ruchira
Nov 20 '18 at 18:32
|
show 1 more comment
1 Answer
1
active
oldest
votes
Because House does not have a public constructor, code outside the class is not allowed to construct a House. But you're trying to do exactly that, here:
House::house = std::make_shared<House>();
The implementation of std::make_shared invokes new to construct a new House, but std::make_shared cannot access the private constructor of House. To fix it, you need to construct the House yourself:
House::house.reset(new House);
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53398927%2fhow-to-access-private-members-of-a-class-from-its-private-constructor%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Because House does not have a public constructor, code outside the class is not allowed to construct a House. But you're trying to do exactly that, here:
House::house = std::make_shared<House>();
The implementation of std::make_shared invokes new to construct a new House, but std::make_shared cannot access the private constructor of House. To fix it, you need to construct the House yourself:
House::house.reset(new House);
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
add a comment |
Because House does not have a public constructor, code outside the class is not allowed to construct a House. But you're trying to do exactly that, here:
House::house = std::make_shared<House>();
The implementation of std::make_shared invokes new to construct a new House, but std::make_shared cannot access the private constructor of House. To fix it, you need to construct the House yourself:
House::house.reset(new House);
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
add a comment |
Because House does not have a public constructor, code outside the class is not allowed to construct a House. But you're trying to do exactly that, here:
House::house = std::make_shared<House>();
The implementation of std::make_shared invokes new to construct a new House, but std::make_shared cannot access the private constructor of House. To fix it, you need to construct the House yourself:
House::house.reset(new House);
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
Because House does not have a public constructor, code outside the class is not allowed to construct a House. But you're trying to do exactly that, here:
House::house = std::make_shared<House>();
The implementation of std::make_shared invokes new to construct a new House, but std::make_shared cannot access the private constructor of House. To fix it, you need to construct the House yourself:
House::house.reset(new House);
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
answered Nov 20 '18 at 18:08
TypeIATypeIA
13.8k2342
13.8k2342
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53398927%2fhow-to-access-private-members-of-a-class-from-its-private-constructor%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
May be the error messages from this MCVE are clearer.
– πάντα ῥεῖ
Nov 20 '18 at 18:09
The majority of the code you've posted is not relevant to the actual problem. Why do you think
make_sharedshould be able to call a private constructor?– Praetorian
Nov 20 '18 at 18:10
@πάνταῥεῖ Clearly clarity is in the eye of the beholder!
– TypeIA
Nov 20 '18 at 18:12
See stackoverflow.com/q/8147027/241631
– Praetorian
Nov 20 '18 at 18:13
@Praetorian here i'm trying to construct the object withing a class and use outside the class using smart pointers problem is clear with shared_ptr here.
– Ruchira
Nov 20 '18 at 18:32