Cfrgtkky

I am trying to compare 2 Strings . I used split method and then toCharArray methods.

After all I used equals to, but at the end I get:

"Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException"



import java.util.Scanner;



public  class LoopsWiederholung {

public static void main (String  args){



    System.out.print("Enter the first String : ");

    Scanner scan1  =  new Scanner(System.in);

    String s1  = scan1.next();

    s1.toUpperCase();



    System.out.print("Enter the second String : ");

    String s2 = scan1.next();

    s2.toUpperCase();

    String s3 = new String[100];

    s3 = s1.split("\ ");



    String s4 = new String[100];

    s4 = s2.split("\ ");



    for (int i = 0 ; i< 100 ; i++){

       if( s3[i].toCharArray().equals(s4[i].toCharArray())){

           System.out.print(s3[i]);

           }

       }





   }

}

So many mistakes, so find my code with comments

    System.out.print("Enter the first String : ");

    Scanner scan1  =  new Scanner(System.in);

    String s1  = scan1.next();

    s1 = s1.toUpperCase();  // Strings are immutable



    System.out.print("Enter the second String : ");

    String s2 = scan1.next();

    s2 = s2.toUpperCase();



    // first check the lengths

    if (s1.length() != s2.length()) {

        System.out.println("not the same");

        return;

    }



    String s3 = s1.split(""); // use this pattern



    String s4 = s2.split("");



    for (int i = 0 ; i< s3.length ; i++){

        if (s3[i].equals(s4[i]))

           System.out.print(s3[i]);

       }

   }

I am think that you either split to get an array of Strings, or use toCharArray() to compare chars

The for loop iterates from 0 to 99, but it assumes that there are 99 elements in that array, so if there isn't you see an ArrayIndexOutOfBoundsException.

One fix may be to change:

String s3 = s1.split("\ ");

and

String s4 = s2.split("\ ");

So that the for loop can then be changed to:

for (int i = 0 ; i< s3.length(); i++){

    if(s3[i].equals(s4[i])){

        System.out.print(s3[i]);

    }

}

As @Scary Wombat mentioned, it is easier to compare two strings using string1.equals(string2) instead of checking character arrays.