Cleaner way to filter data












1















I have data that is in an array of structs. I don't have access to a query variable, and I need to filter down the data. So var I have



    arData = arData.filter(
function(item){
return (form.searchPhrase == ""
||
item.name CONTAINS form.searchPhrase
||
item.company CONTAINS form.searchPhrase
||
item.address CONTAINS form.searchPhrase
||
item.address2 CONTAINS form.searchPhrase
||
item.city CONTAINS form.searchPhrase
||
item.state CONTAINS form.searchPhrase
||
item.zip CONTAINS form.searchPhrase
||
item.email CONTAINS form.searchPhrase
||
item.tel CONTAINS form.searchPhrase
);
});


I am going over all the fields in item.



What I don't like about this is that it seems highly repetitive. It is likely that a new struct key could be added. Or an existing be removed. I am looking for a cleaner way to do this.










share|improve this question





























    1















    I have data that is in an array of structs. I don't have access to a query variable, and I need to filter down the data. So var I have



        arData = arData.filter(
    function(item){
    return (form.searchPhrase == ""
    ||
    item.name CONTAINS form.searchPhrase
    ||
    item.company CONTAINS form.searchPhrase
    ||
    item.address CONTAINS form.searchPhrase
    ||
    item.address2 CONTAINS form.searchPhrase
    ||
    item.city CONTAINS form.searchPhrase
    ||
    item.state CONTAINS form.searchPhrase
    ||
    item.zip CONTAINS form.searchPhrase
    ||
    item.email CONTAINS form.searchPhrase
    ||
    item.tel CONTAINS form.searchPhrase
    );
    });


    I am going over all the fields in item.



    What I don't like about this is that it seems highly repetitive. It is likely that a new struct key could be added. Or an existing be removed. I am looking for a cleaner way to do this.










    share|improve this question



























      1












      1








      1








      I have data that is in an array of structs. I don't have access to a query variable, and I need to filter down the data. So var I have



          arData = arData.filter(
      function(item){
      return (form.searchPhrase == ""
      ||
      item.name CONTAINS form.searchPhrase
      ||
      item.company CONTAINS form.searchPhrase
      ||
      item.address CONTAINS form.searchPhrase
      ||
      item.address2 CONTAINS form.searchPhrase
      ||
      item.city CONTAINS form.searchPhrase
      ||
      item.state CONTAINS form.searchPhrase
      ||
      item.zip CONTAINS form.searchPhrase
      ||
      item.email CONTAINS form.searchPhrase
      ||
      item.tel CONTAINS form.searchPhrase
      );
      });


      I am going over all the fields in item.



      What I don't like about this is that it seems highly repetitive. It is likely that a new struct key could be added. Or an existing be removed. I am looking for a cleaner way to do this.










      share|improve this question
















      I have data that is in an array of structs. I don't have access to a query variable, and I need to filter down the data. So var I have



          arData = arData.filter(
      function(item){
      return (form.searchPhrase == ""
      ||
      item.name CONTAINS form.searchPhrase
      ||
      item.company CONTAINS form.searchPhrase
      ||
      item.address CONTAINS form.searchPhrase
      ||
      item.address2 CONTAINS form.searchPhrase
      ||
      item.city CONTAINS form.searchPhrase
      ||
      item.state CONTAINS form.searchPhrase
      ||
      item.zip CONTAINS form.searchPhrase
      ||
      item.email CONTAINS form.searchPhrase
      ||
      item.tel CONTAINS form.searchPhrase
      );
      });


      I am going over all the fields in item.



      What I don't like about this is that it seems highly repetitive. It is likely that a new struct key could be added. Or an existing be removed. I am looking for a cleaner way to do this.







      coldfusion coldfusion-2018






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 19 '18 at 18:10







      James A Mohler

















      asked Nov 19 '18 at 17:42









      James A MohlerJames A Mohler

      7,106123353




      7,106123353
























          1 Answer
          1






          active

          oldest

          votes


















          2














          Why not just loop over the item's properties then?



          arData = arData.filter(
          function(item){
          if (form.searchPhrase == "") {
          return true;
          }
          for (itemProperty in item){
          if (isSimpleValue(item[itemProperty]) && item[itemProperty] CONTAINS form.searchPhrase) {
          return true;
          }
          }
          return false;
          });


          In case your item might contain properties with a null value (for example if you read JSON from an external API), you want to check structKeyExists(item, itemProperty) in the loop as well.






          share|improve this answer

























            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53380026%2fcleaner-way-to-filter-data%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            2














            Why not just loop over the item's properties then?



            arData = arData.filter(
            function(item){
            if (form.searchPhrase == "") {
            return true;
            }
            for (itemProperty in item){
            if (isSimpleValue(item[itemProperty]) && item[itemProperty] CONTAINS form.searchPhrase) {
            return true;
            }
            }
            return false;
            });


            In case your item might contain properties with a null value (for example if you read JSON from an external API), you want to check structKeyExists(item, itemProperty) in the loop as well.






            share|improve this answer






























              2














              Why not just loop over the item's properties then?



              arData = arData.filter(
              function(item){
              if (form.searchPhrase == "") {
              return true;
              }
              for (itemProperty in item){
              if (isSimpleValue(item[itemProperty]) && item[itemProperty] CONTAINS form.searchPhrase) {
              return true;
              }
              }
              return false;
              });


              In case your item might contain properties with a null value (for example if you read JSON from an external API), you want to check structKeyExists(item, itemProperty) in the loop as well.






              share|improve this answer




























                2












                2








                2







                Why not just loop over the item's properties then?



                arData = arData.filter(
                function(item){
                if (form.searchPhrase == "") {
                return true;
                }
                for (itemProperty in item){
                if (isSimpleValue(item[itemProperty]) && item[itemProperty] CONTAINS form.searchPhrase) {
                return true;
                }
                }
                return false;
                });


                In case your item might contain properties with a null value (for example if you read JSON from an external API), you want to check structKeyExists(item, itemProperty) in the loop as well.






                share|improve this answer















                Why not just loop over the item's properties then?



                arData = arData.filter(
                function(item){
                if (form.searchPhrase == "") {
                return true;
                }
                for (itemProperty in item){
                if (isSimpleValue(item[itemProperty]) && item[itemProperty] CONTAINS form.searchPhrase) {
                return true;
                }
                }
                return false;
                });


                In case your item might contain properties with a null value (for example if you read JSON from an external API), you want to check structKeyExists(item, itemProperty) in the loop as well.







                share|improve this answer














                share|improve this answer



                share|improve this answer








                edited Nov 19 '18 at 19:39

























                answered Nov 19 '18 at 19:18









                AlexAlex

                4,8761831




                4,8761831






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53380026%2fcleaner-way-to-filter-data%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Biblatex bibliography style without URLs when DOI exists (in Overleaf with Zotero bibliography)

                    ComboBox Display Member on multiple fields

                    Is it possible to collect Nectar points via Trainline?